Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTP Range support with a new ResourceRegion class [SPR-14221] #18795

Closed
spring-issuemaster opened this issue Apr 26, 2016 · 6 comments
Closed
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 26, 2016

Brian Clozel opened SPR-14221 and commented

With the latest improvements in HTTP Range support (see #18407), more responsibilities have been given to the ResourceHttpMessageConverter.

Meanwhile, the zero-copy support for static resources in our reactive efforts calls for a new ResourceRegion class. After discussing this matter with Arjen Poutsma, it seems some refactoring can help here.


Affects: 4.3 RC1

Issue Links:

  • #18407 Add support for http byte-range requests for non-static resources ("supersedes")

Referenced from: commits e5dbe12, 42d32ba, 5ac31fb

0 votes, 6 watchers

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 2, 2016

Burkhard Graves commented

What is meant with "zero-copy support for static resources"? Can someone provide a link?

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 2, 2016

Brian Clozel commented

This is related to the upcoming reactive support in Spring 5.
You can find some information in the spring-reactive support repository.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 2, 2016

Brian Clozel commented

I've just pushed a work in progress version for this refactoring here.

Note that this current version has removed the support of HTTP range requests on Controller handlers.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 6, 2016

Kazuki Shimizu commented

Hi Brian Clozel, this commit is correct ?
I tried a latest 4.3.0.BUILD-SNAPSHOT, it is outputting the Accept-Ranges header on two times as follows:

HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Last-Modified: Fri, 06 May 2016 05:10:59 GMT
Content-Encoding: gzip
Accept-Ranges: bytes
Accept-Ranges: bytes
Content-Type: text/css;charset=UTF-8
Content-Length: 19747
Date: Fri, 06 May 2016 05:11:33 GMT

This behavior is specification ?
I think it is not specification.
What do you think ?

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 6, 2016

Juergen Hoeller commented

Good catch! Fixed just in time for 4.3 RC2 now.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 6, 2016

Kazuki Shimizu commented

Hi Juergen Hoeller, thanks for fix.
I will try a latest 4.3.0.BUILD-SNAPSHOT at later!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.