Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpEL should not attempt conversion when exact match is available [SPR-14284] #18856

Open
spring-projects-issues opened this issue May 17, 2016 · 1 comment
Labels
in: core type: enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented May 17, 2016

Christopher Smith opened SPR-14284 and commented

I have an overloaded method where one overload's single parameter exactly matches the argument supplied to the SpEL evaluator. SpEL nevertheless attempts to find a suitable conversion for each of the overloads, which is triggering a bug in Data Commons.

In the case where the supplied argument exactly matches the parameter type (or potentially is an instanceof), SpEL could avoid the conversion attempt entirely.


Affects: 4.3 RC2

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 29, 2016

Juergen Hoeller commented

SpEL's current method resolution algorithm is quite heavily tied to the argument matching step, with conversion checks implied further below. It doesn't seem feasible to revise in the 4.3 timeframe but we can certainly reconsider for 5.0.

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant