Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the relation about concurrency for DefaultJmsListenerContainerFactory and JmsListener [SPR-14290] #18862

Closed
spring-issuemaster opened this issue May 19, 2016 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented May 19, 2016

Manuel Jordan opened SPR-14290 and commented

I am doing a research about JMS

I did realize that to let me work with @JmsListener I need configure a DefaultJmsListenerContainerFactory, it according with the reference documentation.
Until here I am ok and I am able to execute the code.

But I did realize in the current API I have the following:

JmsListener's concurrency attribute
DefaultJmsListenerContainerFactory's setConcurrency method

My points/doubts are:

  • is there a relation between the concurrency attribute and method?
  • one setting overrides or complements the other?

Is not clear the idea with the current documentation.

I could assume that the @JmsListener should 'use' in some way the settings about concurrency from DefaultJmsListenerContainerFactory

Thanks


Affects: 4.2 GA, 4.2.6

Referenced from: commits 9c02a99

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 20, 2016

Stéphane Nicoll commented

@JmsListener is no different from other components in the framework. How complement would even work in practice? The factory creates the listener container to use and each individual JmsListener have a chance to further tune the configuration.

In other words, the setConcurrency method defines the concurrency value to be used by default and you can override that per @JmsListener endpoint.

I think we've asked you this already in the past, please use stackoverflow for questions

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 20, 2016

Manuel Jordan commented

Hello Thanks by the explanation

I understand your point about Stackoverflow, but perhaps the title of this JIRA post should be:

Include in the Reference Documentation and JavaDoc the relation about concurrency for DefaultJmsListenerContainerFactory and JmsListener

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.