Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build to Gradle 2.14.1 [SPR-14362] #18934

Closed
2 tasks done
spring-projects-issues opened this issue Jun 14, 2016 · 5 comments
Closed
2 tasks done

Upgrade build to Gradle 2.14.1 [SPR-14362] #18934

spring-projects-issues opened this issue Jun 14, 2016 · 5 comments
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 14, 2016

Sam Brannen opened SPR-14362 and commented

  • Upgrade the build to Gradle 2.14 once master has been switched to 5.0.
  • Upgrade the build to Gradle 2.14.1 once it has been released.

Issue Links:

  • #19139 Upgrade 4.3.x build to Gradle 2.14.x ("is depended on by")
  • #14205 ReflectionTestUtils.setField() should not call toString() on the target
  • #18789 Upgrade build to Gradle 2.13
  • #19138 Upgrade build to Gradle 3.0
  • #18935 ReflectionTestUtils should defensively invoke toString() on target objects
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 14, 2016

Sam Brannen commented

Resolved in GitHub commit 2fd4462:

Upgrade build to Gradle 2.14

In the process of upgrading the build to use Gradle 2.14, the
setFieldOnLegacyEntityWithSideEffectsInToString() test method in
ReflectionTestUtilsTests began to fail. The reason is that the log
level for ReflectionTestUtils is now DEBUG by default with Gradle 2.14.
The apparent cause is that log4j was present on the test runtime
classpath for the spring-test module with all previous versions of
Gradle (via a transitive optional dependency from another project that
spring-test depends on). Thus the configuration in log4j.properties in
spring-test was previously honored, but with Gradle 2.14 a different
commons logging implementation is picked up.

Thus, in addition to upgrading the build to Gradle 2.14, this commit
introduces an explicit test runtime dependency on log4j in the
spring-test module.

The discovered bug in ReflectionTestUtils regarding DEBUG log level
will be addressed separately.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 15, 2016

Stéphane Nicoll commented

I think we had that conversation before. 4.3 GA is out and I'd like we avoid to upgrade aggressively the build infrastructure. We can obviously resume this once master becomes 5.0 SNAP

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 15, 2016

Sam Brannen commented

OK. I'll revert the change in master and assign this issue to 5.0 M1.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 15, 2016

Juergen Hoeller commented

Gradle 2.14 seems to be the end of the 2.x line, so generally worth upgrading to in the 4.3.x line... at some point at least.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 15, 2016

Stéphane Nicoll commented

Given the extensive maintenance period of 4.3 I agree but I am not keen on doing this right now. Especially with regards to the upcoming 4.3.1.RELEASE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants