Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CGLIB 3.2.4 [SPR-14385] #18958

Closed
spring-projects-issues opened this issue Jun 20, 2016 · 6 comments
Closed

Upgrade to CGLIB 3.2.4 [SPR-14385] #18958

spring-projects-issues opened this issue Jun 20, 2016 · 6 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 20, 2016

Lucas Pate opened SPR-14385 and commented

CGLIB has been updated to version 3.2.3 to fix a bug and two regressions: https://github.com/cglib/cglib/releases/tag/RELEASE_3_2_3


Affects: 4.2.6

Reference URL: https://github.com/cglib/cglib/releases/tag/RELEASE_3_2_3

Issue Links:

  • #18506 Upgrade to CGLIB 3.2.2
  • #19713 Upgrade to CGLIB 3.2.5

Referenced from: commits 848562d, ea5baeb, f60c6c9

Backported to: 4.2.7

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 21, 2016

Lucas Pate commented

I may have misunderstood the release notes for CGLIB 3.2.3. I think the warning in the release notes about the bug and regressions applies to version 3.2.3 rather than fixing those issues in 3.2.3.

I have been experiencing a permgen leak with Spring Framework 4.2.6, and it is related to CGLIB. I built the 4.2.6 tag with CGLIB 3.2.0 (4.2.5 version), and the permgen leak was not present. I also built the 4.2.6 tag with CGLIB 3.2.3, but I am still experiencing a permgen leak.

I pulled the trunk version of CGLIB with the latest bug/regression fixes and applied it to Spring 4.2.6 and my permgen leak has been resolved. CGLIB will need to be upgraded to 3.2.4 when it is released.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 21, 2016

Juergen Hoeller commented

We haven't noticed any regressions in our own tests against 4.3.1.BUILD-SNAPSHOT which has been upgraded to CGLIB 3.2.3 already. That said, we'll pick up CGLIB 3.2.4 right away once available: ideally, if it get released ahead of July 1st (our 4.3.1 & 4.2.7 target date)...

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 22, 2016

Lucas Pate commented

I created a JUnit test that demonstrates the perm gen leak in Spring Boot 1.3.5 (4.2.6). It does not occur in Boot 1.3.3 (4.2.5). I don't know how to add this test to your test suites, since it was somewhat difficult to reproduce.

https://github.com/lucaspate/bugs/tree/master/SpringAopPermGenLeak

Should I open a bug for it?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 22, 2016

Juergen Hoeller commented

We don't have perm-gen tests in our test suite, and I'd rather leave it at that. Let's upgrade to CGLIB 3.2.4 and run your external test against it. Feel free to raise it with the CGLIB guys, asking for an early 3.2.4 release...

To avoid any misunderstandings: My comment above was just referring to regressions since Spring Framework 4.2.6 / CGLIB 3.2.2. The upgrade to CGLIB 3.2.3 does not seem to cause any new issues at least.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 26, 2016

Juergen Hoeller commented

Upgrading to the just released CGLIB 3.2.4 right away, repurposing this ticket for it.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 27, 2016

Lucas Pate commented

I picked up the latest 4.3.1.BUILD-SNAPSHOT this morning, and the perm-gen leak I experienced is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants