Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defensively access deprecated AbstractHttpClient class from Apache HttpComponents [SPR-14422] #18993

spring-projects-issues opened this issue Jul 1, 2016 · 0 comments
type: enhancement


Copy link

spring-projects-issues commented Jul 1, 2016

Juergen Hoeller opened SPR-14422 and commented

During an upgrade attempt to HttpAsyncClient 4.1.2, it turns out that - under certain constellations - we get build warnings for AbstractHttpClient's use of @GuardedBy. Not diving too deep there, the root of our problem is that we're still compiling against the long-deprecated AbstractHttpClient class for legacy checks in HttpComponentsClientHttpRequestFactory and HttpComponentsHttpInvokerRequestExecutor. Since that class may go away at any time in a future HttpClient release, let's reflectively access it instead and therefore get rid of the build warnings as well as not insisting on its presence at runtime anymore. We're just using it for a legacy property check anyway which we'll remove in 5.0 for good.

Affects: 4.3 GA

Issue Links:

Referenced from: commits 4478354, 1c73664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
type: enhancement
None yet

No branches or pull requests

2 participants