Allow specifying CompilationCustomizer for Groovy based beans [SPR-14585]

[spring-projects-issues]

Alexander Zobkov opened SPR-14585 and commented

Groovy (since 1.8) supports customizing compilation process. For example:

• adding various types of imports to the compilation unit:http://docs.groovy-lang.org/latest/html/api/org/codehaus/groovy/control/customizers/ImportCustomizer.html,
• applying AST transformations without specifing them in sources:
  http://docs.groovy-lang.org/latest/html/gapi/org/codehaus/groovy/control/customizers/ASTTransformationCustomizer.html

Adding support for this feature allows to increase expressiveness of source files for groovy beans by hiding "noise" of explicit imports and AST annotations. With usage of DSL and groovy syntax sugar, source files for groovy beans can look like plain text in english that can be used and understandable for non programmers.

I tried to enable Import customizer with existing Spring API but failed to to do so, see attachment for code snippet.

---

Affects: 4.3 GA

Attachments:

• 1.txt (1.77 kB)

Issue Links:

• #9888 ScriptFactory for JSR-223
• #15635 ScriptExecutor for JSR-223

Referenced from: commits da56758, 53819c4, fbeff47, 433764d, 6a0d9d3

[spring-projects-issues]

Juergen Hoeller commented

Since our existing customizer-ref mechanism in the spring-lang namespace allows for arbitrary customizer types already, I've simply added a corresponding GroovyScriptFactory(scriptSourceLocator, compilationCustomizer) constructor which means that both GroovyObjectCustomizer and any CompilationCustomizer type are accepted there now.

[spring-projects-issues]

Juergen Hoeller commented

I've revised GroovyScriptFactory to allow for multiple CompilationCustomizers as well as for a full CompilerConfiguration object and added analogous configuration options to GroovyScriptEvaluator.

[spring-projects-issues]

Alexander Zobkov commented

Thanks for implementing this improvement request!

I think one thing left. The note you originally added in src/asciidoc/integration.adoc needs to be updated according to the "Consistent support for CompilationCustomizers as well as custom CompilerConfiguration" commit.

[spring-projects-issues]

Juergen Hoeller commented

Good point, I've updated it now.