Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for context paths in Spring Web Reactive [SPR-14726] #19291

Closed
spring-projects-issues opened this issue Sep 16, 2016 · 1 comment
Closed

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Sep 16, 2016

Rossen Stoyanchev opened SPR-14726 and commented

At present there is no concept of a context path in Spring Web Reactive but there is an expressed need on some level at least.

Per Dave Syer:
It's a feature used quite a bit in Spring Boot and in Spring Cloud where pre-configured apps are created. The thing I use the context path for the most is running multiple apps on localhost with different cookies. That's probably worth considering as a common scenario. Doesn't have to be done with a context path, but I think that makes the most sense.

Per #19279:
A context path can also "creep in" as a side effect of running in a Servlet container.

For M2 a getContextPath() method will be introduced in ServerHttpRequest as a short term solution to the issue for #19279. However we should really consider explicit support for a context path in our configuration across all supported server runtimes.


Affects: 5.0 M1

Issue Links:

  • #19279 Reactive path matching does not consider servlet context path

Referenced from: commits b92d541, 0bace1b

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 20, 2016

Rossen Stoyanchev commented

Dave Syer this is now available in master b92d54. See the commit details and example and the ContextPathIntegrationTests. Let me know if you have any comments.

Brian Clozel, see if it makes sense for exposing from the Spring Boot web reactive starter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants