Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableAsync javadoc not clear enough [SPR-14793] #19359

Closed
spring-projects-issues opened this issue Oct 10, 2016 · 1 comment
Closed

EnableAsync javadoc not clear enough [SPR-14793] #19359

spring-projects-issues opened this issue Oct 10, 2016 · 1 comment

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 10, 2016

Slava Semushin opened SPR-14793 and commented

The sentence

To be used on @Configuration classes as follows, where MyAsyncBean is a user-defined type with one or more methods annotated with either Spring's @Async annotation ...
maybe understanding wrong.

For example, should I add @EnableAsync to all configuration classes that contain @Async beans? Is it possible to place @EnableAsync on one configuration and put the beans with @Async to another configuration?

Here is a quote from to Andy Wilkinson in gitter:

They can be in separate locations
@EnableAsync needs to go on a @Configuration class

I think that documentation could be improved.


Reference URL: http://docs.spring.io/spring/docs/4.3.x/javadoc-api/org/springframework/scheduling/annotation/EnableAsync.html

Issue Links:

  • #19447 Document supported return types for @Async methods

Referenced from: commits 7a8bf8e, fe59bc2, ab232a5

Backported to: 4.2.9

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 11, 2016

Stéphane Nicoll commented

Juergen Hoeller I gave that a try in ab232a5 - reconsidering things, I am not sure that the javadoc can be much improved but the split in two examples does not seem to hurt either.

Can you please review and backport it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants