Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpRequest#getURI() with Netty based engines [SPR-14794] #19360

Closed
spring-projects-issues opened this issue Oct 10, 2016 · 0 comments
Closed
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 10, 2016

Sébastien Deleuze opened SPR-14794 and commented

Currently HttpRequest#getURI() only exposes the request path without the scheme, host and port defined with Netty based engines (Reactor Netty, RxNetty) while other engines provide these informations correctly (Jetty, Tomcat, Undertow).

Reactor may allow to get hostname and port via NettyChannel#remoteAddress(). RxNetty does not expose Netty channel informations so we may use server host and port informations. In both cases, we don't have the scheme information so we maybe have to make sure that we don't rely on that in a mandatory way.


Issue Links:

  • #19113 Reactive HTTP request CORS Support ("is depended on by")
  • #19706 @RequestParam injects a raw undecoded string for reactive HTTP requests

Referenced from: commits 0cc330e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants