Skip to content

/spring-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty4ClientHttpRequestFactory should use SSL if port is 443 or scheme is https [SPR-14889] #19455

Closed
spring-issuemaster opened this issue Nov 9, 2016 · 0 comments

Comments

@spring-issuemaster
Copy link
Collaborator

commented Nov 9, 2016 •
edited

Mark Paluch opened SPR-14889 and commented

Currently, Netty4ClientHttpRequestFactory uses SSL if either the port is 443 or not port is given and the scheme is https. URIs having a port specified other than 443 but using https use plain-text connections so SSL is not applied.

So https://localhost:8200 connects via plaintext but should use SSL.

Affects: 4.3.4

Issue Links:

  • #19310 Netty4ClientHttpRequestFactory should configure a default SslContext
  • #19668 Netty4ClientHttpRequestFactory should use SNI for TLS connections

Referenced from: pull request #1235, and commits 6261106, 5285f53
@spring-issuemaster spring-issuemaster added this to the 4.3.5 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web type: bug
Projects
None yet
Milestone
  4.3.5
2 participants
@spring-issuemaster @bclozel
You can’t perform that action at this time.