spring or shiro jsonp(AbstractJsonpResponseBodyAdvice) bug [SPR-14967]

[spring-projects-issues]

Say.li opened SPR-14967 and commented

@RestControllerAdvice
public class JsonpAdvice extends AbstractJsonpResponseBodyAdvice {

public JsonpAdvice() {
    super("callback");
}

@Override
protected void beforeBodyWriteInternal(MappingJacksonValue bodyContainer, MediaType contentType, MethodParameter returnType, ServerHttpRequest request, ServerHttpResponse response) {
    System.out.println(request.getURI());
    super.beforeBodyWriteInternal(bodyContainer, contentType, returnType, request, response);
}

}

The above method, if there is in the @RequestMapping method
Shiro:
SecurityUtils.getSubject().login(new UsernamePasswordToken("admin", "admin", false)) or
SecurityUtils.getSubject().logout(),
beforeBodyWriteInternal method will not be called,

Normal @RequestMapping method in normal.

---

No further details from SPR-14967

[spring-projects-issues]

Brian Clozel commented

I don't understand the issue here.
Could you share a small project showing the problem? You can create a repro project of your own or send a PR on spring-framework-issues.
Don't forget to explain what result you were expecting and what you actually get.
Thanks!

[spring-projects-issues]

Say.li commented

Sorry, English is not good.
localhost:8080/login?username=admin&password=admin&callback=a
Expect: a({"status":false,"code":"1001","msg":"没有这个用户","data":null})
Actual:{"status":false,"code":"1001","msg":"没有这个用户","data":null}

AbstractJsonpResponseBodyAdvice. beforeBodyWriteInternal method not implemented,

not used SecurityUtils.getSubject() @RequestMapping expectation and Practice normal.

Don't know is the shrio problem, or spring problem.

[spring-projects-issues]

Say.li commented

spring boot 1.4.2.RELEASE
shiro 1.3.2

[spring-projects-issues]

Brian Clozel commented

As far as I understand, Apache Shiro handles requests at its Servlet Filter level.
Spring's JSONP support acts at the Controller handler level (meaning the request has to hit an actual Spring Controller).

If you're looking for JSONP support with Shiro, I'd suggest getting in touch with the Shiro project then.

[spring-projects-issues]

Say.li commented

@RequestMapping("logout")
public Result logout(HttpServletResponse response) throws JsonProcessingException {
    SecurityUtils.getSubject().logout();
    Result result = new Result();
    result.setStatus(true);
    result.setCode("0000");
    result.setMsg("退出成功");
    return result;
}

Method is used in the @RequestMapping oh?

[spring-projects-issues]

Say.li commented

Aren't you 4:50 in the morning?

[spring-projects-issues]

Brian Clozel commented

Please create a small project that demonstrates the issue.