Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading parameter names and JavaDoc in ResolvableType [SPR-14976] #19542

Closed
spring-projects-issues opened this issue Dec 5, 2016 · 2 comments
Closed

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Dec 5, 2016

Oliver Drotbohm opened SPR-14976 and commented

ResolvableType exposes overloads for forClass(…). The one taking a single Class parameter says sourceClass and gives an implementation type as parameter in the JavaDoc. The one taking two Class parameters takes a sourceClass first, but in that case, it's not the type binding the generic parameters but the type exposing the parameters to bind (List in the example above). So in the second case the parameter binding the types is called implementationClass but is semantically equivalent to what has been called sourceClass in the one-parameter method.


Affects: 4.2.8, 4.3.4

Backported to: 4.2.9

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 8, 2016

Juergen Hoeller commented

I've revised the terminology there a bit, using plain clazz for the simple variants and baseType vs implementationClass for that specific two-arg forClass variant. This should be less confusing overall since it doesn't mis-suggest the same semantics anymore.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 8, 2016

Oliver Drotbohm commented

Thanks! 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.