Misleading parameter names and JavaDoc in ResolvableType [SPR-14976]

[spring-projects-issues]

Oliver Drotbohm opened SPR-14976 and commented

ResolvableType exposes overloads for forClass(…). The one taking a single Class parameter says sourceClass and gives an implementation type as parameter in the JavaDoc. The one taking two Class parameters takes a sourceClass first, but in that case, it's not the type binding the generic parameters but the type exposing the parameters to bind (List in the example above). So in the second case the parameter binding the types is called implementationClass but is semantically equivalent to what has been called sourceClass in the one-parameter method.

---

Affects: 4.2.8, 4.3.4

Backported to: 4.2.9

[spring-projects-issues]

Juergen Hoeller commented

I've revised the terminology there a bit, using plain clazz for the simple variants and baseType vs implementationClass for that specific two-arg forClass variant. This should be less confusing overall since it doesn't mis-suggest the same semantics anymore.

[spring-projects-issues]

Oliver Drotbohm commented

Thanks! 🙃