Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request matchers for query parameters in MockRestRequestMatchers [SPR-14995] #19561

Closed
spring-projects-issues opened this issue Dec 8, 2016 · 3 comments
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Dec 8, 2016

János Schmidt opened SPR-14995 and commented

There isn't any request matcher factory method for query parameters in MockRestRequestMatchers.

Such request matchers would be use full in the component spring-cloud-contract-wiremock of project spring-cloud-contract when creating a MockRestServiceServer from a WireMock JSON. The request matchers of test components are used for the creation but there is no assertion against query parameters.

The implementation of query parameter request matchers could be there as well but imho it would be more beautiful if the request matchers are in the same place, in the same code base.


Affects: 4.3.4

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 9, 2016

Rossen Stoyanchev commented

Sure, would you like to submit a pull request?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 9, 2016

János Schmidt commented

I have already submited onet :)

Sam Brannen redirected me here to create a new JIRA item first.

#1263

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 9, 2016

Rossen Stoyanchev commented

Good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.