Provide a way to unregister a DataSource in SQLErrorCodesFactory [SPR-15006]

[spring-projects-issues]

John Poth opened SPR-15006 and commented

Spring currently caches the datasources and are removed by the Garbage collector once they are no longer used. It would be great to provide a way to allow the user to manually unregister a Datasource and not have to wait until a GC kicks in. This is a problem in OSGI and the current workaround is to get the error codes by Datasource name so the cache isn't used.

So something like:

public DataSource unregisterDatabase(DataSource dataSource) {
		synchronized (this.dataSourceCache) {
			return this.dataSourceCache.put(dataSource);
		}
	}

Would be great!

---

Affects: 4.3.4

Referenced from: commits 8190e78, b825528

[spring-projects-issues]

Juergen Hoeller commented

I've added an unregisterDatabase(DataSource) method, also changing SQLErrorCodesFactory's internal cache from a WeakHashMap to a our own ConcurrentReferenceHashMap which we're using in all other places these days (for better concurrency and for memory-friendly soft references by default).

[spring-projects-issues]

John Poth commented

That was quick :) Awesome, thanks!