Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin ScriptTemplateView tests [SPR-15059] #19625

Closed
spring-projects-issues opened this issue Dec 27, 2016 · 2 comments
Closed

Add Kotlin ScriptTemplateView tests [SPR-15059] #19625

spring-projects-issues opened this issue Dec 27, 2016 · 2 comments
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Dec 27, 2016

Sébastien Deleuze opened SPR-15059 and commented

As demonstrated on https://github.com/sdeleuze/kotlin-script-templating/, Kotlin 1-1-M04 supports JSR 223 and is usable with our ScriptTemplateView since all the blocking issues reported in Kotlin 1.1-M02 have been fixed (see KT-14713, KT-14707 and KT-14706).

Since Kotlin 1.1 is able to generate Kotlin 1.0 bytecode, we should add Kotlin + ScriptTemplateView tests like there are currently for Jython, JRuby, Nashorn, etc.


Issue Links:

  • #19630 Support i18n and nested template loading in ScriptTemplateView render function ("is depended on by")

Referenced from: commits badde3a, ef43400

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 27, 2016

Sébastien Deleuze commented

I postpone this issue to RC1, I prefer to stay on a stable Kotlin version for now (especially given the recent release of Kotlin 1.0.6 that contains features not yet available in Kotlin 1.1-M04). There is nothing preventing using Kotlin 1.1 Script support with current codebase, this issue is only about adding integration tests.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 1, 2017

Sébastien Deleuze commented

Done via commit ef43400 and badde3a.

I am discussing with Kotlin team to see if they could integrate ready to use JSR 223 support in kotlin-script-runtime in their next milestone instead of requiring kotlin-script-util with 3 excluded dependencies + a META-INF file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants