Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Reactive ScriptTemplateView [SPR-15063] #19629

Closed
spring-projects-issues opened this issue Dec 28, 2016 · 1 comment
Closed

Add a Reactive ScriptTemplateView [SPR-15063] #19629

spring-projects-issues opened this issue Dec 28, 2016 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Dec 28, 2016

Sébastien Deleuze opened SPR-15063 and commented

JSR 223 support would make sense for Reactive application. See https://github.com/sdeleuze/kotlin-script-templating for an interesting use case with Kotlin.

One open question to be solved is how can we deal with ScriptEngine that are not thread safe. In Spring MVC we use a sharedEngine boolean property + ThreadLocal, in reactive world we will need to find another solution if we want to support this, like a ScriptEngine pool or just getting a new ScriptEngine for each request.


Referenced from: commits b503e46

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 9, 2017

Sébastien Deleuze commented

Resolved by this commit. For now when sharedEngine is set to false we create a new ScriptEngine instance for each request. That could be later improved by a ScriptEngine instance pool if necessary.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0 M5 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants