Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON Streaming [SPR-15104] #19671

Closed
spring-projects-issues opened this issue Jan 6, 2017 · 4 comments
Closed

Add support for JSON Streaming [SPR-15104] #19671

spring-projects-issues opened this issue Jan 6, 2017 · 4 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 6, 2017

Sébastien Deleuze opened SPR-15104 and commented

Currently Jackson2JsonEncoder supports only encoding Flux as JSON array. This could stay the default, but we also need to support encoding as JSON stream with specified String separator.

Implementing that as a hint would be flexible and make sense IMO.


Issue Links:

Referenced from: commits 6b9b023, ef550c4

1 votes, 2 watchers

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 3, 2017

Sébastien Deleuze commented

I have created a pull request to be reviewed.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 6, 2017

Sébastien Deleuze commented

Fixed with this commit.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 12, 2017

Sébastien Deleuze commented

I reopen this issue since JsonStreamingIntegrationTests are disabled because this test seems fragile.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 13, 2017

Sébastien Deleuze commented

Fixed by this commit that flushes after each element when JSON streaming is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants