Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@RequestParam injects a raw undecoded string for reactive HTTP requests [SPR-15140] #19706

Closed
spring-projects-issues opened this issue Jan 14, 2017 · 2 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 14, 2017

Eiichi Sato opened SPR-15140 and commented

Query strings should be URL-decoded before injected into @RequestParam
variables.

Current behaviour (Spring Web Reactive)
@ResponseBody
@GetMapping("/search")
public String search(@RequestParam("q") String q) {
    LOG.info("search: q = {}", q);
    return q;
}
$ curl -s 'http://localhost:8080/search?q=%20%2B+%C3%A0'
%20%2B+%C3%A0
Expected behaviour (= Spring WebMVC behaviour)
$ curl -s 'http://localhost:8080/search?q=%20%2B+%C3%A0'
 + à

Affects: 5.0 M4

Issue Links:

1 votes, 3 watchers

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 14, 2017

Eiichi Sato commented

I have just submitted a pull request: #1297

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 17, 2017

Rossen Stoyanchev commented

Thanks for the report!

There were additional issues in dealing with encoded query strings for RxNetty, Reactor Netty, and Undertow. Those should now be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants