Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieLocaleResolver maxAge documentation wrong [SPR-15155] #19721

Closed
spring-projects-issues opened this issue Jan 17, 2017 · 1 comment
Closed
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 17, 2017

Mike Noordermeer opened SPR-15155 and commented

https://docs.spring.io/spring/docs/current/spring-framework-reference/html/mvc.html#mvc-localeresolver-cookie states:

cookieMaxAge default: Integer.MAX_INT

The default is null though, so either the documentation needs updating, or the CookieLocaleResolver needs updating (null creates a session-bound cookie, which is kind of useless if there is also a SessionLocaleResolver)


Affects: 4.3.5

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 17, 2017

Juergen Hoeller commented

We're effectively using the Servlet container's defaults there if not explicitly specified. I've updated our documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants