Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies are missing from the poms of the latest 5.0 snapshots [SPR-15167] #19733

Closed
spring-projects-issues opened this issue Jan 19, 2017 · 4 comments
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 19, 2017

Andy Wilkinson opened SPR-15167 and commented

It appears to be related to starting to use the dependency management plugin to import Reactor's bom. I'm guessing there's a clash between it and whatever was adding the optional dependencies to the pom (the propdeps plugin?).

I'll investigate and hopefully open a PR once I've figured out what the root cause is and how to fix it.


Affects: 5.0 M5

Referenced from: commits b1fed6f, 6fe7b17

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 19, 2017

Andy Wilkinson commented

Pull request: #1301

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 19, 2017

Brian Clozel commented

Thanks Andy Wilkinson, I'll merge this right away.

Quick question - now that we're using Gradle 3.3, should we use compileOnly and drop the propdeps plugin?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 19, 2017

Brian Clozel commented

This isn't fixed yet. Since SPR-PUB-4411, we're getting the following:

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':spring-build-src:artifactoryPublish'.
> File '/opt/bamboo-home/xml-data/build-dir/SPR-PUB-JOB1/buildSrc/build/poms/pom-default.xml' specified for property 'mavenDescriptor' does not exist.

Note: "propdeps-maven" is already applied by "gradle/publish-maven.gradle", which is itself applied on all projects but "spring-build-src".

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 19, 2017

Brian Clozel commented

This second PR fixed the remaining issues.

Thanks Andy Wilkinson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants