Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractValueAdaptingCache#toStoreValue should throw an exception if the value is null and allowNulls is false [SPR-15173] #19739

Closed
spring-projects-issues opened this issue Jan 20, 2017 · 1 comment
Assignees
Labels
in: core type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 20, 2017

Stéphane Nicoll opened SPR-15173 and commented

If a Cache is configured to not allow null values, toStoreValue can still return null instead of throwing an exception. This leads to a non informative exception message if the underlying cache provider tries to store the value down the road.


Affects: 4.3.5

Issue Links:

  • DATAREDIS-606 RedisCache Tests in Spring Data Redis 2.0.x builds fail testing null values
  • #20252 AbstractValueAdaptingCache does not allow for flexible null value serialization
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 20, 2017

Stéphane Nicoll commented

I did backport that fix until I realized I shouldn't so I've reverted the change in 4.3.x. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants