InvocableHandlerMethod should call GenericTypeResolver with getBeanType() and only once [SPR-15186] #19752
Labels
in: messaging
Issues in messaging modules (jms, messaging)
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: bug
A general bug
Milestone
Artem Bilan opened SPR-15186 and commented
The code to review:
Looks like we always call that
GenericTypeResolver.resolveParameterType()
for the same reason and for the same arguments.That could be done directly in the
initMethodParameters()
, which is called from the constructor.Plus we should keep in mind that
getBean()
not always returns target object. There isbeanName
-based constructor. Consider to switch to thegetBeanType()
.We have an interesting observation in Spring Integration when this
InvocableHandlerMethod
approach is slower than Compiled SpEL, but that is different story...Plus it would be great to reconsider properties and accessors visibility in the
InvocableHandlerMethod
andDefaultMessageHandlerMethodFactory
. Right now they are not good for extension...Thanks
Affects: 4.3.5
Issue Links:
Referenced from: commits 8038fb9, a98a618
The text was updated successfully, but these errors were encountered: