Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettableListenableFuture may be both set and canceled successfully [SPR-15202] #19766

Closed
spring-projects-issues opened this issue Jan 29, 2017 · 1 comment
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 29, 2017

Ivan Sopov opened SPR-15202 and commented

Please see this jcstress-based test:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/spring/SettableListenableFutureTest.java

There is no such bug in guava:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/guava/SettableFutureTest.java

Or in CompletableFuture from JUC:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/CompletableFutureTest.java


Affects: 4.3.6

Issue Links:

Referenced from: commits 9666fcc, dec1c93

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 31, 2017

Juergen Hoeller commented

We're consistently obtaining the done/cancelled state from our inner SettableTask now, so that it is guaranteed to be in sync with a value/exception set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants