New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyclic bean methods cause IllegalArgumentException instead of BeanCurrentlyInCreationException [SPR-17358] #19778
Comments
Andy Wilkinson commented This test that expects a
|
Andy Wilkinson commented This test is also suffering from the same problem. Interestingly, perhaps, is that it's only that one test that's affected. All the others in the class are still getting the expected
|
Juergen Hoeller commented Thanks for your efforts there, Andy... It looks like we found the reason for why we lazily cached the factory method handle there before. In order to make qualifier-based lookup with |
Juergen Hoeller commented I've addressed the immediate regressions in master so that we're not dragging this out too far. Let me know whether this actually covers the failing tests in Boot. As for the intention behind the original change #13532, I'll give it one more pass tomorrow. Let's see whether there is a way to make early factory method caching work without regressions... |
Phil Webb commented Boot is green again. Thanks! |
Dave Syer commented Opened the wrong one by mistake |
Filip Hrisafov commented Just to put some trace to a similar issue that we had due to a complex Spring Boot auto configuration in 2.0. Seems like what was done to resolve this has resolved the issues we were having (when there were problems in the configurations). The Spring Boot issue is spring-projects/spring-boot#13222. Tried my reproducal project and it works correctly (displays a proper error) now. Thanks a lot for fixing it. |
Madhura Bhave opened SPR-17358 and commented
Following some recent changes on master, tests related to
BeanCurrentlyInCreationException
in Spring Boot have started failing. These tests expect the cyclic beans to throw aBeanCurrentlyInCreationException
but instead we get aIllegalArgumentException: wrong number of arguments
.It might be related to the change here.
Affects: 5.1.1
Issue Links:
0 votes, 5 watchers
The text was updated successfully, but these errors were encountered: