Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HtmlUnit 2.25+ [SPR-15319] #19882

Closed
spring-issuemaster opened this issue Mar 6, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Mar 6, 2017

Juergen Hoeller opened SPR-15319 and commented

HtmlUnit 2.25 changed its WebRequest.getCharset() method to return a Charset instead of a String, breaking binary compatibility with our HtmlUnitRequestBuilder.

As of 5.0 RC1, we can simply require HtmlUnit 2.25+ and use the new signature accordingly. In 4.3.8, we can reflectively tolerate both signatures.


Issue Links:

  • #19604 Revisit dependency baseline: Jetty 9.4+, OkHttp 3+

Referenced from: commits 9de9761, e61e8d5

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 7, 2017

Phil Webb commented

Annoying that that's changed in a minor patch release. Any plans for 2.25 support in 4.3.x?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 7, 2017

Juergen Hoeller commented

Good point, let's tolerate both signatures in 4.3.x for the time being...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.