Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SpringExtension.getApplicationContext() public [SPR-15340] #19903

Closed
spring-issuemaster opened this Issue Mar 10, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Mar 10, 2017

Ralf Stuckert opened SPR-15340 and commented

If you are writing a custom junit-jupiter extension for spring that needs access to the application context, it would be desirable to use the SpringExtension.getApplicationContext() method, just like the built-in extensions.

Currently this method is package private which introduces some restrictions. Is that intended for some reason, or is there maybe a better way to get access to the app context? Otherwise it would be helpful if you make this method public.


Affects: 5.0 M5

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Mar 14, 2017

Sam Brannen commented

Juergen Hoeller, thanks for tackling this one.

I originally considered making that method public, but I was a bit hesitant due to the (possibly unforeseeable changing) nature/scope of the ExtensionContext.Store in JUnit Jupiter. However, famous last words: I suppose it's OK to open this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.