Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-core source jar contains two copies of source code [SPR-15462] #20022

Closed
spring-projects-issues opened this issue Apr 19, 2017 · 6 comments
Closed
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Apr 19, 2017

Dave Syer opened SPR-15462 and commented

The commons-logging classes in spring-core (see #19081) seem to contain 2 copies of the source code (in the same file for each class). I think that makes them unreadable by Eclipse because I can't read the code in the IDE.


Affects: 5.0 RC1

Issue Links:

  • #19081 Revisit Commons Logging vs java.util.logging vs SLF4J vs Log4j 2

Referenced from: commits cf6031f

0 votes, 6 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 19, 2017

Dave Syer commented

Actually it's all the sources in spring-core (maybe other jars I didn't check). So probably something screwed up in the build config globally.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 22, 2017

Stéphane Nicoll commented

Juergen Hoeller do we care? I thought we were about to move those to a separate jar?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 22, 2017

Juergen Hoeller commented

According to Dave's comment, it affects all sources in spring-core and not just the Commons Logging classes... Let's double-check what we're producing here.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 24, 2017

Stéphane Nicoll commented

I can see a duplication of asm and commons logging and certain packages indeed.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 24, 2017

Andy Wilkinson commented

Stéphane asked me to take a look at this. It's caused by a bug in Kotlin's Gradle plugin that causes src/main/java to be listed twice in sourceSets.main.allSource. You can work around the problem by setting duplicatesStrategy = DuplicatesStrategy.EXCLUDE on the sourcesJar task.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 24, 2017

Sébastien Deleuze commented

I added a comment on Kotlin bug tracker specifying this bug is annoying for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants