spring-core source jar contains two copies of source code [SPR-15462]

[spring-projects-issues]

Dave Syer opened SPR-15462 and commented

The commons-logging classes in spring-core (see #19081) seem to contain 2 copies of the source code (in the same file for each class). I think that makes them unreadable by Eclipse because I can't read the code in the IDE.

---

Affects: 5.0 RC1

Issue Links:

• #19081 Revisit Commons Logging vs java.util.logging vs SLF4J vs Log4j 2

Referenced from: commits cf6031f

0 votes, 6 watchers

[spring-projects-issues]

Dave Syer commented

Actually it's all the sources in spring-core (maybe other jars I didn't check). So probably something screwed up in the build config globally.

[spring-projects-issues]

Stéphane Nicoll commented

Juergen Hoeller do we care? I thought we were about to move those to a separate jar?

[spring-projects-issues]

Juergen Hoeller commented

According to Dave's comment, it affects all sources in spring-core and not just the Commons Logging classes... Let's double-check what we're producing here.

[spring-projects-issues]

Stéphane Nicoll commented

I can see a duplication of asm and commons logging and certain packages indeed.

[spring-projects-issues]

Andy Wilkinson commented

Stéphane asked me to take a look at this. It's caused by a bug in Kotlin's Gradle plugin that causes src/main/java to be listed twice in sourceSets.main.allSource. You can work around the problem by setting duplicatesStrategy = DuplicatesStrategy.EXCLUDE on the sourcesJar task.

[spring-projects-issues]

Sébastien Deleuze commented

I added a comment on Kotlin bug tracker specifying this bug is annoying for us.