Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deceptive error message in Spring Test ModelResultMatchers [SPR-15487] #20047

Closed
spring-issuemaster opened this issue Apr 26, 2017 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

commented Apr 26, 2017

Danny Trunk opened SPR-15487 and commented

The error message "No errors for attribute [...]" in attributeHasNoErrors is deceptive. The error message is displayed if the attribute actually has errors. It should be "Errors for attribute [...]" and maybe a list of the errors would be helpful.


Affects: 4.3.8

Reference URL: https://github.com/spring-projects/spring-framework/blob/master/spring-test/src/main/java/org/springframework/test/web/servlet/result/ModelResultMatchers.java#L147

Issue Links:

  • #20048 Allow for HttpOnly cookie result matcher
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2017

Juergen Hoeller commented

Good catch! Fixed in master now; I'll backport it to 4.3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.