Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for HttpOnly cookie result matcher [SPR-15488] #20048

Closed
spring-projects-issues opened this issue Apr 26, 2017 · 5 comments
Closed

Allow for HttpOnly cookie result matcher [SPR-15488] #20048

spring-projects-issues opened this issue Apr 26, 2017 · 5 comments
Assignees
Labels
in: test type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Apr 26, 2017

Nikola Yovchev opened SPR-15488 and commented

On some occasions, it's very useful to check whether a Cookie is httpOnly or not.

CookieResultMatchers

provides ready-made matchers for value, age, path, etc, but not for httpOnly.


Affects: 4.3.7

Reference URL: #1373

Issue Links:

  • #20047 Deceptive error message in Spring Test ModelResultMatchers

Referenced from: commits 04f0f13, 9b64702

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 27, 2017

Nikola Yovchev commented

Pull req #1373 is supposed to implement it.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 27, 2017

Juergen Hoeller commented

Thanks for the suggestion, your PR looks fine functionality-wise!

However, we recently revised the matcher implementations to consistently use a lambda implementation style as well as assertion messages including the cookie name. I've locally added an httpOnly method along your suggestion already, fitting our revised stylistic arrangement.

If you'd like your actual PR to be merged, you'd have to rebase it and align its implementation style. Otherwise I can also proceed with my local changes (not pushed yet, waiting for other stuff to be finished first).

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 27, 2017

Nikola Yovchev commented

Perfect, I preferred lambda anyway, was just following convention in the existing code. Will rebase with the new lambda style.

Which branch should I rebase against?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 27, 2017

Juergen Hoeller commented

Just to current master, we can straightforwardly merge it there.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 27, 2017

Nikola Yovchev commented

Thanks! Did it, now is lambized.

e80de55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants