Skip to content

/spring-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache spring.factories loads [SPR-15509] #20068

Closed
spring-issuemaster opened this Issue May 3, 2017 · 1 comment

Comments

Assignees

@snicoll snicoll

Labels
in: core type: enhancement
Projects
None yet
Milestone
  5.0 RC1
2 participants
@spring-issuemaster @snicoll
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented May 3, 2017

Phil Webb opened SPR-15509 and commented

Currently SpringFactoriesLoader reloads properties files on each call. Whilst this doesn't appear to be particularly expensive in terms of CPU, it does cause some garbage objects due to an 8K buffer that Properties creates each time.

We could cache the loaded properties to save repeated loading the same file.

Affects: 4.3.8
@spring-issuemaster

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

spring-issuemaster commented May 3, 2017

Phil Webb commented

https://github.com/philwebb/spring-framework/tree/SPR-15509

@spring-issuemaster spring-issuemaster closed this May 8, 2017

@spring-issuemaster spring-issuemaster added type: enhancement in: core labels Jan 11, 2019

@spring-issuemaster spring-issuemaster added this to the 5.0 RC1 milestone Jan 11, 2019

@spring-issuemaster spring-issuemaster assigned snicoll Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.