Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandlerExecutionChain toString() may miss interceptors [SPR-15525] #20084

spring-projects-issues opened this issue May 7, 2017 · 0 comments
in: web type: bug


Copy link

@spring-projects-issues spring-projects-issues commented May 7, 2017

QBNemo opened SPR-15525 and commented


  1. HandlerExecutionChain has attribute: interceptors and interceptorList, and can be classed into three state : state-i, state-ii, state-iii .
  2. calling getInterceptors, addInterceptor, or addInterceptors , can change state.
  3. construct a HandlerExecutionChain using a handler which is not instanceof HandlerExecutionChain, will be state-i;
  4. construct a HandlerExecutionChain using a handler which is instanceof HandlerExecutionChain, will be state-ii;
  5. calling toString in state-i will get the wrong number of interceptors. for example:
    LocaleChangeInterceptor local = new LocaleChangeInterceptor();
    HandlerExecutionChain chain = new HandlerExecutionChain(new Object(), local);
    "chain" has one interceptor "local", but the toString() missed it.

Affects: 4.3.8, 5.0 M5


Referenced from: pull request #1417, and commits 92f18a4, e522fec

@spring-projects-issues spring-projects-issues added type: bug in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3.9 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
in: web type: bug
None yet

No branches or pull requests

2 participants