Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using multiple configLocations with SqlMapClientFactoryBean shouldn't wire up caches to be flushed multiple times [SPR-15606] #20165

Closed
spring-projects-issues opened this issue Jun 1, 2017 · 2 comments
Assignees
Labels
in: data status: invalid

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 1, 2017

Dennis Waldherr opened SPR-15606 and commented

SqlMapClientFactoryBean#buildSqlMapClient reuses SqlMapConfigParser to parse each config location.
SqlMapConfigParser#addSqlMapConfigNodelets registers a call to SqlMapConfiguration#finalizeSqlMapConfig which in turn calls wireUpCacheModels each time the end of a document is reached (once per configLocation).
So for each configLocation a call to wireUpCacheModels is made. It registers all CacheModels again and again for the same statements...


Affects: 4.3.5

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 1, 2017

Juergen Hoeller commented

Which version of SqlMapClientFactoryBean are you referring to? This hasn't been part of the Spring Framework core for quite a while... The current Mybatis Spring integration lives at https://github.com/mybatis/spring instead.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 2, 2017

Dennis Waldherr commented

Ah thanks, you're right it's part of mybatis, I fell for the package name.

@spring-projects-issues spring-projects-issues added status: invalid in: data type: enhancement labels Jan 11, 2019
@spring-projects-issues spring-projects-issues removed the type: enhancement label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data status: invalid
Projects
None yet
Development

No branches or pull requests

2 participants