Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent @Nullable on AbstractDestinationResolvingMessagingTemplate [SPR-15670] #20229

Closed
spring-projects-issues opened this issue Jun 15, 2017 · 0 comments
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 15, 2017

Gary Russell opened SPR-15670 and commented

In AbstractDestinationResolvingMessagingTemplate, some methods are missing @Nullable on MessagePostProcessor.

For example,

public <T> void convertAndSend(String destinationName, T payload, MessagePostProcessor postProcessor)

delegates to

public <T> void convertAndSend(String destinationName, T payload, @Nullable Map<String, Object> headers, @Nullable MessagePostProcessor postProcessor)

Also

public <T> T convertSendAndReceive(String destinationName, Object request, Class<T> targetClass,
			MessagePostProcessor postProcessor)

public <T> T convertSendAndReceive(String destinationName, Object request, Map<String, Object> headers,
			Class<T> targetClass, MessagePostProcessor postProcessor)

delegate to methods in the superclass that have @Nullable MessagePostProcessor postProcessor.


Affects: 5.0 RC2

Issue Links:

  • #20099 Introduce null-safety of Spring Framework API

Referenced from: commits 7e25127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants