Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UrlBasedCorsConfigurationSource for leveraging PathPatternParser [SPR-15688] #20247

spring-projects-issues opened this issue Jun 21, 2017 · 0 comments


Copy link

@spring-projects-issues spring-projects-issues commented Jun 21, 2017

Sébastien Deleuze opened SPR-15688 and commented

On Spring MVC side, AbstractHandlerMapping propagates PathMatcher changes to the UrlBasedCorsConfigurationSource used for CORS support.

Spring WebFlux CORS infrastructure is a very close port for Spring MVC one using WebFlux API instead of MVC one, but as dicussed this morning WebFlux UrlBasedCorsConfigurationSource#setPathMatch is still present but not used and should probably replaced by a PathPatternParser based setter and used in AbstractHandlerMapping to make sure both use the same one (notice that I am not sure that customization of PathPatternParser is supported on WebFlux AbstractHandlerMapping yet).

Referenced from: commits 9c93521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants