Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getAttribute on ServerWebExchange and WebSession to align with Map getOrDefault [SPR-15718] #20274

Closed
spring-projects-issues opened this issue Jun 29, 2017 · 3 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 29, 2017

Rossen Stoyanchev opened SPR-15718 and commented


Affects: 5.0 RC2

Referenced from: commits 8f4eb23, 9253fac, 7de6cfa

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 29, 2017

Rob Winch commented

I'd like to request that there is also easy to get a value with no default value and no casting. Something like: <T> T getAttribute(String attrName).

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 29, 2017

Rossen Stoyanchev commented

Indeed that is the plan. All of the following actually:

<T> T getAttribute(String name);

<T> T getRequiredAttribute(String name);

<T> T getAttributeOrDefault(String name, T defaultValue);

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 29, 2017

Rob Winch commented

Awesome! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants