Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
CustomizableTraceInterceptor should allow INVOCATION_TIME placeholder in setExceptionMessage and make stack trace logging configurable [SPR-15763] #20318
At one time, the CustomizableTraceInterceptor did not correctly calculate method invocation time when an exception was thrown. That issue was fixed with #6468.
However, the setExceptionMessage() method still throws an exception if the INVOCATION_TIME placeholder is used. This extra check simply needs removed.
Jonathan Baker commented
What do you think about making the logging of the stack trace configurable? It is an easy enough fix, just call logger.trace(message) instead of logger.trace(message, exception)
In our case we enable the interceptor in production on all methods annotated with
It would be nice to be able to disable stack trace logging from the interceptor.
Juergen Hoeller commented
Good point! As a further part of this ticket, I've added a corresponding