Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] Warning message about private final methods. [SPR-15820] #20375

Closed
spring-issuemaster opened this issue Jul 26, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jul 26, 2017

Dariusz Bacinski opened SPR-15820 and commented

Recently in Kotlin version 1.1.2 there was a change regarding opening (making not final) Koltin classes . Now private methods are not being opened. This is actual change:

JetBrains/kotlin@5d4cefc

Unfortunately Spring is very verbose regarding printing warning into logs about final methods. Which leads to a warning about private final methods like this:

"INFO org.springframework.aop.framework.CglibAopProxy - Final method [private final ...] cannot get proxied via CGLIB: Calls to this method will NOT be routed to the target instance and might lead to NPEs against uninitialized fields in the proxy instance."

logger.info("Final method [" + method + "] cannot get proxied via CGLIB: " +

As discussed with Sebastien Deleuze @koltinlang Slack this should be checked only for public and protected methods.


Affects: 5.0 RC2

Referenced from: commits 1e07468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.