Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringValidatorAdapter fails to retrieve value for Bean Validation 2.0's "<list element>" literal [SPR-15839] #20394

Closed
spring-issuemaster opened this issue Jul 31, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jul 31, 2017

Michał Sobkiewicz opened SPR-15839 and commented

It seems like SpringValidatorAdapter doesn't handle <list element> literal. It is sometimes expected, as far as I understand JSR 380 spec correctly. Please, review http://beanvalidation.org/2.0/spec/2.0.0.cr3/#valueextractordefinition-builtinvalueextractors and correct me if I'm wrong. Note <iterable element>, <map key> and <map value> too.

I hope that "Reference URL" contains SSCCE. Will keep it for some time. I've attached all interesting files just in case something goes wrong.

As you (will be able to) see, validator.validate(bean, errors) ends up with IllegalStateException. I would expect one field error instead.

One more thing: I believe it's not about "bean property versus direct field access". Getters and setters are here. To be sure, I checked not only BeanPropertyBindingResult but DirectFieldBindingResult too. Same result.


Affects: 5.0 RC3

Reference URL: https://github.com/perceptron8/spr-13482

Attachments:

Issue Links:

  • #20363 Compatibility with Hibernate Validator 6.0 GA ("is depended on by")
  • #20490 Wrong exception thrown by Springframework Beans when Type validation fails ("is duplicated by")
  • #18061 Compatibility with Bean Validation 2.0 and JPA 2.2
  • #20470 Error on type argument constraint validation failure

Referenced from: commits de09f8c, 26284ca

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2017

Michał Sobkiewicz commented

How about few additional tests for <map key> and <map value>? If you like, feel free grab them from: https://github.com/perceptron8/spr-13482/blob/master/src/test/java/SpringValidatorAdapterTests.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.