Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemUtils.copyRecursively no longer replaces existing files [SPR-15845] #20400

Closed
spring-issuemaster opened this issue Aug 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Aug 3, 2017

Andy Wilkinson opened SPR-15845 and commented

In 4.3, copyRecursively would replace existing files. In 5.0, the move to Files.copy means that existing files are no longer overwritten and the copy fails with a FileAlreadyExistsException.

I wonder if this change was intentional (and could perhaps be mentioned in the javadoc), or if using StandardCopyOption.REPLACE_EXISTING would be appropriate.


Affects: 5.0 RC3

Issue Links:

  • #20401 FileSystemUtils.deleteRecursively always returns false

Referenced from: commits fabc9c2

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 3, 2017

Juergen Hoeller commented

Good catch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.