Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemUtils.copyRecursively no longer replaces existing files [SPR-15845] #20400

Closed
spring-projects-issues opened this issue Aug 3, 2017 · 1 comment
Closed

FileSystemUtils.copyRecursively no longer replaces existing files [SPR-15845] #20400

spring-projects-issues opened this issue Aug 3, 2017 · 1 comment
Assignees
@jhoeller
Labels
in: core type: regression
Milestone
5.0 RC4

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 3, 2017 •
edited

Andy Wilkinson opened SPR-15845 and commented

In 4.3, copyRecursively would replace existing files. In 5.0, the move to Files.copy means that existing files are no longer overwritten and the copy fails with a FileAlreadyExistsException.

I wonder if this change was intentional (and could perhaps be mentioned in the javadoc), or if using StandardCopyOption.REPLACE_EXISTING would be appropriate.

Affects: 5.0 RC3

Issue Links:

Referenced from: commits fabc9c2
@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Aug 3, 2017

Juergen Hoeller commented

Good catch...

@spring-projects-issues spring-projects-issues added type: regression in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0 RC4 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core type: regression
Projects
None yet
Milestone
5.0 RC4
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues