Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemUtils.deleteRecursively always returns false [SPR-15846] #20401

Closed
spring-issuemaster opened this issue Aug 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Aug 3, 2017

Andy Wilkinson opened SPR-15846 and commented

The root is deleted in postVisitDirectory by a call to Files.delete(dir). Once the walking of the file tree has completed Files.deleteIfExists(root) is called and its result is returned. This result is always false due to the earlier File.delete(dir) call.


Affects: 5.0 RC3

Issue Links:

  • #20400 FileSystemUtils.copyRecursively no longer replaces existing files
  • #20304 Revise FileSystemResource / FileSystemUtils / FileCopyUtils towards NIO.2

Referenced from: commits fabc9c2

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 3, 2017

Juergen Hoeller commented

We're checking Files.exists upfront now, relying on the file tree walking to actually delete the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.