FileSystemUtils.deleteRecursively always returns false [SPR-15846]

[spring-issuemaster]

Andy Wilkinson opened SPR-15846 and commented

The root is deleted in postVisitDirectory by a call to Files.delete(dir). Once the walking of the file tree has completed Files.deleteIfExists(root) is called and its result is returned. This result is always false due to the earlier File.delete(dir) call.

---

Affects: 5.0 RC3

Issue Links:

• #20400 FileSystemUtils.copyRecursively no longer replaces existing files
• #20304 Revise FileSystemResource / FileSystemUtils / FileCopyUtils towards NIO.2

Referenced from: commits fabc9c2

[spring-issuemaster]

Juergen Hoeller commented

We're checking Files.exists upfront now, relying on the file tree walking to actually delete the root.