Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
WebAsyncManager should cancel task thread on timeout [SPR-15852] #20407
We are implementing a REST service with and endpoint that does some processing, part of it being in a database transaction. We would like to use WebAsyncTask to run this task in a separate thread and establish a timeout. However, we find that when the timeout has elapsed the service returns the corresponding Timeout Exception but the thread continues to work finishing the database transaction while we would like it to fail and perform a rollback.
We understand that the way to control it is by honoring isInterrupted() inside our code before committing the transaction. This way the executor thread will know that the timeout has exceeded and will exit with an exception performing a rollback. However it seems that the thread is not interrupted.
Which is the right way to do this? Is the spring platform supposed to call .interrupt() when the timeout is activated or we have to do this ourselves?
Juergen Hoeller commented
Indeed, interruption is the way to go here. We can't interrupt the task thread directly since we're dispatching to it behind an
Jordi Puigsegur commented
Ok. Thanks. I'll keep an eye on this thread.