Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hook in DefaultWebSessionManager to support creating custom WebSession implementation [SPR-15876] #20431

Closed
spring-issuemaster opened this issue Aug 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Aug 18, 2017

Rob Winch opened SPR-15876 and commented

It would be nice if DefaultWebSessionManager provided a hook for creating a new WebSession vs instantiating it directly. This is necessary in Spring Session because Spring Session repositories allow creating a custom implementation based on the session store type. This allows for optimizations on how/when the session is persisted. For example, the Redis implementation of Spring Session tracks the changes that have been made and only persists the changes.

Spring Session can still accomplish what it needs, but it must create its own WebSessionManager which requires a lot more work than just providing a WebSessionStore


Affects: 5.0 RC3

Issue Links:

  • #20430 DefaultWebSessionManager requires DefaultWebSession

Referenced from: pull request #1507

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 24, 2017

Rob Winch commented

I have a Pull Request that addresses this. It is combined with efforts around #20430 #1507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.