Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate Spring Web annotations from spring web [SPR-15882] #20437

Closed
spring-projects-issues opened this issue Aug 21, 2017 · 1 comment
Closed

Seperate Spring Web annotations from spring web [SPR-15882] #20437

spring-projects-issues opened this issue Aug 21, 2017 · 1 comment
Assignees
Labels
status: declined type: task

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 21, 2017

Itamar Benjamin opened SPR-15882 and commented

Hi,
In my company we have an API project for every service, and each service that uses another one is dependent on the latter's API project in gradle.
I know this is not the recommended way to work by spring but that's convenient for us for the time being.

In these API projects we have the controller's interface, which needs @RequestMapping and other spring-web annotations. Since these annotations come with the entire spring-web code, we get conflicts in some of our client applications, and the API jar, which should be very slim, brings with it many spring-web classes.

it will be very useful for us, and i'm sure for other teams that work like us, to have a separate annotation package published (similar to swagger annotations package -
https://mvnrepository.com/artifact/io.swagger/swagger-annotations)

Thanks!


Affects: 4.3.10

1 votes, 4 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 21, 2017

Brian Clozel commented

We've considered a few issues like this (including, for example, #13143).

We have to strike the right balance between structuring our codebase and having a reduced number of well identified modules.
The change you're suggesting would also go against the fact that we need to avoir split packages (see JDK9 modules requirements); splitting annotations in a separate module would require us to change the whole package namespace...

@spring-projects-issues spring-projects-issues added status: declined type: task labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined type: task
Projects
None yet
Development

No branches or pull requests

2 participants