Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StompDecoder Logs Null Session IDs for Heartbeats [SPR-15937] #20491

Closed
spring-issuemaster opened this Issue Sep 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Sep 7, 2017

Steve Roy opened SPR-15937 and commented

When enabling the TRACE log level on the StompDecoder, a null session id is logged for heartbeats in the Spring WebSocket STOMP client.

Here is a logging sample:

11:39:03 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
11:39:30 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
11:39:31 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
11:39:32 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
11:39:36 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null

Affects: 4.3.9

Referenced from: commits 07a0a31, aa4ae7a

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 7, 2017

Steve Roy commented

Why was the ticket closed?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 8, 2017

Juergen Hoeller commented

Ah sorry, I meant to add that we're not logging "with session null" now anymore but rather just "Decoded heart-beat" in such a case.
Or are you rather wondering about heart-beats without a session in the first place?

In any case, the commit isn't pushed yet. Coming along with a few others later today.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 8, 2017

Steve Roy commented

ok - I didn't see the commit so I was wondering what the status was.

Yes, the pending commit addresses the concern.

While developing / debugging it raises questions to see a null session id in the log statements. It looks like having the session id available to that location in the code would require some design / code re-organization for a minor issue. Just removing the session id from the log statement helps for now - thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.