New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bean(nameOfBean) doesn't work with Spring Framework 5.0.1 on AspectJ 1.8.12 [SPR-16161] #20709
Comments
Francisco Lozano commented If using aspectJ 1.8.11, it seems to work... |
Francisco Lozano commented using aspectj 1.9.0.RC1 also works ... |
Juergen Hoeller commented Andy Clement, since this issue seems to be limited to AspectJ 1.8.12 in particular... could it be possibly a specific regression there? I'm rather puzzled that it seems to work with both 1.8.11 and 1.9 RC1 but not with 1.8.12 inbetween... |
Andy Clement commented 1.8.12 included some performance enhancements for Spring AOP. After release it was discovered one went a bit too far resulting in pointcut parsers sometimes having two underlying 'bean' handlers. If that happens then you get the error above. This was reverted in 1.9.0.RC1 until more thinking could be done and indeed the change isn't in the 1.8 master github now either. A 1.8.13 would behave the same as 1.9.0.RC1 - still a big boost to Spring AOP but without the dangerous change. |
Andy Clement commented If you want to try it out, try 1.8.13.BUILD-SNAPSHOT which is on the snapshot repo.spring.io repository. |
Andy Clement commented AspectJ 1.8.13 has just been sent off to central, hopefully be there in the next few hours. This should fix the issue. |
Juergen Hoeller commented Alright, Andy - thanks to your timely work, I'll consider this as resolved for 5.0.2 then! Master is upgraded to AspectJ 1.8.13 and 1.9 RC2 now. |
Francisco Lozano commented Regardless of this fix, which version should be considered the right one to use in Spring 5.0? 1.9RC2 or 1.8.13? |
Juergen Hoeller commented We're using 1.9 RC2 for building the |
Andrei Ivanov commented Andy Clement A bit off topic, but where can the code changes for AspectJ be seen? I've been looking at the log of git://git.eclipse.org/gitroot/aspectj/org.aspectj.git, but I don't too many see changes there. |
Andy Clement commented Andrei Ivanov I need to do some tidying up, I currently have two active branches moving forward ahead of master and I need to switch the Java9 one to be master. Right now the branches are: RB_V1_8 - the 1.8 release branch where the 1.8.13 work has been done earlyJava9 - where the java9 work is being done. I typically view it through github mirror: |
Francisco Lozano opened SPR-16161 and commented
Trying to upgrade to Spring 5.0.1. I'm using AspectJ 1.8.12 as per the release notes of 5.0.1, even if the issues referred to 1.9 RC.
This aspect worked well with 4.3:
But in 5.0.1, I get:
Affects: 5.0.1
Referenced from: commits 7bcbdbb
The text was updated successfully, but these errors were encountered: