Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stomp Broker Relay may ignore configured destination prefixes [SPR-16265] #20812

Closed
spring-projects-issues opened this issue Dec 5, 2017 · 3 comments
Assignees
Labels
in: messaging status: backported type: regression
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Dec 5, 2017

Rémi Alvergnat opened SPR-16265 and commented

There's a bug in StompHeaderAccessor class, method updateStompCommandAsClientMessage.

Problem occurs when getCommand() returns null. setHeader is called with SEND command, but command variable is not set after that and method returns null instead of SEND

It cause the stomp broker relay to ignore destination prefixes because command is null (see StompBrokerRelayMessageHandler L507).


Affects: 4.3.13, 5.0.2

Reference URL: #1616

Issue Links:

  • #20713 Reduce access on headers for STOMP messaging

Referenced from: commits 4fe94df, 76dcde9

Backported to: 4.3.14

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 11, 2017

Rossen Stoyanchev commented

PR #1616

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 11, 2017

Rossen Stoyanchev commented

It looks like this was introduced recently with the changes for #20713.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 13, 2017

Christoph Dreis commented

Just saw this. Good catch. As I did #20713 originally, I worried that I might have broken it from the start, but it seems to have only sneaked into the backport.

@spring-projects-issues spring-projects-issues added in: messaging type: regression status: backported labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging status: backported type: regression
Projects
None yet
Development

No branches or pull requests

2 participants