Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SpEL syntax in reference documentation [SPR-16315] #20862

Closed
spring-issuemaster opened this issue Dec 19, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Dec 19, 2017

Sviatoslav Hryb opened SPR-16315 and commented

Spring Framework Reference (Testing) https://docs.spring.io/spring/docs/5.0.2.RELEASE/spring-framework-reference/testing.html contains incorrect code fragment in section 3.5.6. Testing request and session scoped beans

The incorrect fragment is:

<beans>

    <bean id="userService"
            class="com.example.SimpleUserService"
            c:loginAction-ref="loginAction" />

    <bean id="loginAction" class="com.example.LoginAction"
            c:username="{request.getParameter('user')}"
            c:password="{request.getParameter('pswd')}"
            scope="request">
        <aop:scoped-proxy />
    </bean>

</beans>

The problem is that c:username="&#123;request.getParameter('user')&#125;" should have prefix #&#123; for correct SpEL syntax. The same is true for c:password="&#123;request.getParameter('pswd')&#125;"


Affects: 4.3.13, 5.0.2

Referenced from: commits 8aa94ae, 0d151b0

Backported to: 4.3.14

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 7, 2018

Juergen Hoeller commented

Stéphane Nicoll, this seems to be an escaping problem... Any insight into asciidoc's behavior here?

Oddly enough, we were only escaping the '#' character in the first case before. Removing that escape sequence made the character disappear in three places now, also in the session.getAttribute('theme') example further below.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2018

Stéphane Nicoll commented

That block was using verbatim substitution but there was no need to do that. I've removed it and the code snippet is fine now. Also backported to 4.3.x.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 13, 2018

Sam Brannen commented

Oops!

I thought I fixed that in this commit, but obviously I did not.

Thanks, Stéphane Nicoll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.