Track tasks and feature requests
Join 36 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprisesLarge transaction timeout value (Integer.MAX_VALUE for example) results in transaction expiring immediately after starting. [SPR-16316] #20863
Comments
This comment has been minimized.
This comment has been minimized.
|
Juergen Hoeller commented Good catch! Thanks for raising this. |
spring-issuemaster
closed this
Jan 23, 2018
spring-issuemaster
added
type: bug
in: data
status: backported
labels
Jan 11, 2019
spring-issuemaster
added this to the 5.0.3 milestone
Jan 11, 2019
spring-issuemaster
assigned
jhoeller
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
spring-issuemaster commentedDec 20, 2017
Razvan Popian opened SPR-16316 and commented
Setting a large transaction timeout value like Integer.MAX_VALUE in the
@Transactionalannotation causes the transaction to timeout immediately. The problem appears to be in the setTimeoutInSeconds method in the org.springframework.transaction.support.ResourceHolderSupport class. The timeout in seconds is multiplied by 1000. Two ints multiplied in java result in an int so for example Integer.MAX_VALUE * 1000 equals -1000. This is why the transaction times out immediately as described..Affects: 3.2.18, 4.3.6
Referenced from: pull request #1633, and commits e502541, b9e03cb
Backported to: 4.3.14