Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultLifecycleProcessor throws BeanNotOfRequiredType for null beans (cause of NullBean instance cannot be converted) [SPR-16343] #20890

Closed
spring-issuemaster opened this issue Jan 3, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 3, 2018

Stefan Mueller opened SPR-16343 and commented

When initializing applications with null-beans of type Lifecycle, DefaultLifecycleProcessor.getLifecycleBeans throws a BeanNotOfRequiredType exception rather then ignoring null-beans like in previous spring versions.

DefaultLifecycleProcessor should be fixed to not call the ctx.getBean(name, type) method but rather getBean(name) and check for type explicitely.

Reason/Background: In earlier versions of Spring the ctx.getBean(name, type) method returned null for null-beans. Since Spring 5, Spring returns the NullBean instance but that cannot be converted to required type.

See as well #20582, #20711 and #20889.


Affects: 5.0.2

Issue Links:

  • #20889 BeanNotOfRequiredTypeException (NullBean instead of null) when calling ApplicationContext.getBean(name, type)

Referenced from: commits 977550f

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 7, 2018

Juergen Hoeller commented

We can indeed do a manual instanceof Lifecycle check there in the subsequent if condition. Fixed for 5.0.3 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.